Alex Behm has posted comments on this change.

Change subject: IMPALA-4569: fuzz test fixes
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5502/1/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:

Line 59:           'disable_codegen' : cls.DISABLE_CODEGEN_VALUES, 'mem_limit' 
: cls.MEM_LIMITS}))
Should we add BATCH_SIZES here as well? I can see how you'd want to run several 
batch sizes on the same file, but the same would also apply to 
DISABLE_CODEGEN_VALUES. Not asking you to change anything, just curious what 
you think.


-- 
To view, visit http://gerrit.cloudera.org:8080/5502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1942ceef252ec3e6171a0a54722b66a7d9abbd7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to