Dan Hecht has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers ......................................................................
Patch Set 15: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4715/14/be/src/runtime/bufferpool/suballocator.cc File be/src/runtime/bufferpool/suballocator.cc: Line 107: > WHEN_NEEDED will be convenient for porting the existing exec nodes, and I t But once we switch to using NEVER, will we still need WHEN_NEEDED? In general, I think we should keep things simple until we have a need, to avoid adding dead code or over engineering things. But if you're confident both will need both, then okay, but otherwise, let's just add back the extra policy when we actually have a need for it. http://gerrit.cloudera.org:8080/#/c/4715/15/be/src/runtime/bufferpool/suballocator.h File be/src/runtime/bufferpool/suballocator.h: PS15, Line 128: bein missing space -- To view, visit http://gerrit.cloudera.org:8080/4715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bfe0e429f67ad273f7c7d0816703a9e6c3da788 Gerrit-PatchSet: 15 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
