Lars Volker has posted comments on this change.

Change subject: add thousands seperator to cardinality
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5587/1//COMMIT_MSG
Commit Message:

PS1, Line 7: seperator
Nit: separator


Line 7: add thousands seperator to cardinality
Is there a Jira for this?


http://gerrit.cloudera.org:8080/#/c/5587/1/www/query_plan.tmpl
File www/query_plan.tmpl:

Line 98:     var label_val = "" + node["output_card"].toLocaleString();
Is there a way to test this? If not, can you add a short comment to the commit 
message, explaining how you tested this?


-- 
To view, visit http://gerrit.cloudera.org:8080/5587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23bfbd8d235c7f1ab7a22d640e557d8ae9a00947
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to