John Russell has posted comments on this change. Change subject: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5592/1/docs/impala.ditamap File docs/impala.ditamap: Line 846: <keydef audience="Cloudera" href="topics/impala_data_sources.xml" keys="data_sources"/> > Why should this be hidden? The data sources feature has always been considered "not ready for prime time" and the associated doc has never been reviewed or completed. The actual content has always been hidden, I just accidentally left off the audience= attribute when making the corresponding <keydef> tag. The unhidden <keydef> tag has no effect by itself, but it was causing warnings in any doc build. -- To view, visit http://gerrit.cloudera.org:8080/5592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Anonymous Coward #250 Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-HasComments: Yes
