Tim Armstrong has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: Line 141 > AtomicInt::Add says it returns the new value. If the new value was greater Right - if this wasn't the last decrement, then we can exit early because some other call will do the cleanup. If if it's > 0 though we have no guarantee about when the cleanup will happen. If another thread is executing this function at the same time, it might clean up the QueryState immediately after this thread decrements it. -- To view, visit http://gerrit.cloudera.org:8080/5615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
