Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4212: Add sink output expressions to explain output ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4783/1/fe/src/main/java/org/apache/impala/planner/DataSink.java File fe/src/main/java/org/apache/impala/planner/DataSink.java: Line 34: import java.util.ArrayList; Looks like you don't actually use several of these - ArrayList, Splitter, WordUtils. Line 77: outputExprs_ = outputExprs; single line http://gerrit.cloudera.org:8080/#/c/4783/1/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: Line 34: return String.format("PLAN-ROOT SINK [%s]\n", getOutputExprsString()); I guess you're ignoring prefix because its always going to be an empty string here? Maybe note that. Line 38: return initThriftSink(TDataSinkType.PLAN_ROOT_SINK); single line -- To view, visit http://gerrit.cloudera.org:8080/4783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c3a47d7ee28a9efb1405dd1a6ef9b7a83931f6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
