Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5662
Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses ...................................................................... IMPALA-4739: ExprRewriter fails on HAVING clauses SelectStmt.rewriteExprs() rewrote the pre-analysis form of the HAVING predicate; the fix was to rewrite the post-analysis version. SelectStmt.rewriteExprs() is also not effective for the grouping exprs, but I decided to leave that alone, since it won't result in an error. The rewriter rule tests are too narrow right now, because they only apply to select list exprs (which is why it missed the problem with the Having clause). I added a functional test for this particular jira, but we should also restructure the rewriter rule tests themselves to apply to all syntactic elements that can see rewrites. Change-Id: Ife74c61f549f620c42f74928f6474e8a5a7b7f00 --- M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test 3 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5662/1 -- To view, visit http://gerrit.cloudera.org:8080/5662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife74c61f549f620c42f74928f6474e8a5a7b7f00 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]>
