Lars Volker has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template ......................................................................
Patch Set 1: (3 comments) Thanks for the reviews, please see PS2. http://gerrit.cloudera.org:8080/#/c/5664/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: Line 34: """Test that /query_profile_encoded error message does not have any leading newlines. > Not just no newlines, but the expected line in the case of a missing query. Done http://gerrit.cloudera.org:8080/#/c/5664/1/www/raw_text.tmpl File www/raw_text.tmpl: Line 17: under the License. > We should also add a comment saying that the whitespace is critical so that Done Line 18: }}{{contents}} > Any other templates like this that should be fixed? I manually went through www/*.tmpl and this one was the only one that seemed to have the issue. -- To view, visit http://gerrit.cloudera.org:8080/5664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b688aa9e2423b0271c8891a983e5b22707d8dbc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
