Tim Armstrong has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5669/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: PS1, Line 142: \ nit: the line continuation shouldn't be necessary inside parentheses. Might as well fix it while we're here. http://gerrit.cloudera.org:8080/#/c/5669/1/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: PS1, Line 86: -logbuflevel=-1 We should document the importance of this somewhere. Maybe in the comment for assert_impalad_log_contains()? -- To view, visit http://gerrit.cloudera.org:8080/5669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f21284338ee7b4374aca249b6556282b0148389 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
