Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5648/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: Line 305: public void TestCreateTableWCommentPartition() throws AnalysisException { just roll this into an existing test, no need to have something separate (each statement takes a little bit of time to execute). http://gerrit.cloudera.org:8080/#/c/5648/2/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test File testdata/workloads/functional-query/queries/QueryTest/show-create-table.test: Line 119: # With a table comment and a partition same here, roll this into an existing test case. -- To view, visit http://gerrit.cloudera.org:8080/5648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a33cfd142b473997fdc3acfe3f0966bc7ed784 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
