Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently treat 9999 as upper bound for timestamp year ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5665/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1458: TestIsNull("cast('10000-01-01 00:00:00' as timestamp)", TYPE_TIMESTAMP); This test case passes both with and without this patch. (I don't think we are able to parse a 5 digit year). I think we still need a case of '9999-12-31 23:59:59' + 1 second (one which would fail without the patch and pass with the patch). Line 1478: TestTimestampValue("cast(-17987443200 as timestamp)", I would add 2 more cases: casting -17987443199 and 253402300800 as timestamp. (both should result in a null). Line 1503: intentional blank line? PS2, Line 3612: 23:99:99 Is this a mistake? -- To view, visit http://gerrit.cloudera.org:8080/5665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf23b40833017789d879e5da7bb10384129e2d10 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
