Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements ......................................................................
Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5486/4/tests/comparison/model_translator.py File tests/comparison/model_translator.py: Line 799: return data_type_class.__name__.upper() > It's basically the same case as with Oracle: the code exists and maybe work I never had a need to run against MySQL instead of PostgreSQL. I would vote to remove this code. In general I would vote to remove code that is not being run regularly. Maybe keep it on some branch until we are ready to start running it regularly again. http://gerrit.cloudera.org:8080/#/c/5486/4/tests/comparison/query_profile.py File tests/comparison/query_profile.py: PS4, Line 647: partial' > Old habit related to C, when you could mistake = for == in comparison. If y Yeah, makes sense. It's fine, don't change it. -- To view, visit http://gerrit.cloudera.org:8080/5486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842b41f0eed07ab30ec76d8fc3cdd5affb525af6 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
