Jim Apple has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored ......................................................................
Patch Set 3: Code-Review+1 (1 comment) I'm ok with +2ing this as soon as clang-tidy warnings induced by these new annotations in the be tests are fixed. Thanks for doing this, Tim - I'm sure it will help me sanity-check my code and catch bugs sooner. http://gerrit.cloudera.org:8080/#/c/4878/3//COMMIT_MSG Commit Message: PS3, Line 10: in place of Status Used with both Status and bool in this patch, and not in-place-of, but in-addition-to. -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
