Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses ......................................................................
Patch Set 5: Code-Review+2 > I don't fully understand the consequences of not analyzing these > exprs. Based on Jim's comment, some parts ofthe code seem to assume > that the exprs remain analyzed after rewriting. > > Would a more conservative approach be to check if the exprs are > analyzed upon entry to the function, then re-analyze them only if > they were? Jim reported the output of a test failure, which is now fixed. I want to leave it at that for now, the code is convoluted enough as it is. -- To view, visit http://gerrit.cloudera.org:8080/5662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife74c61f549f620c42f74928f6474e8a5a7b7f00 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
