Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit ......................................................................
Patch Set 2: (1 comment) Hopefully that is a little clearer. http://gerrit.cloudera.org:8080/#/c/5683/2/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: Line 282: Status Write(DiskIoMgr* io_mgr, DiskIoRequestContext* io_ctx, File* file, > Maybe briefly note pre/post conditions on write_in_flight_ here and for Ret Done -- To view, visit http://gerrit.cloudera.org:8080/5683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a624212bc17f7824e6d14ad143c0d5894206f8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
