David Knupp has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5720/2/tests/statestore/test_statestore.py File tests/statestore/test_statestore.py: Line 18: # TODO(KRPC): Re-enable. > Instead of adding a # on every line, I would suggest to add ''' (three sing Or theoretically (meaning I haven't tried this) you could add a pytest skipif mark at the module (global) scope. pytestmark = pytest.mark.skipif(reason="All tests to be rewritten in C++") -- To view, visit http://gerrit.cloudera.org:8080/5720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dbf12b9ecd71d26d239d31c19b487175194c766 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
