Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent 
paths.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5743/1//COMMIT_MSG
Commit Message:

PS1, Line 22: The treatment of such
            : partitions is very inefficient.
I could be wrong about it, but I don't think this is an accurate description of 
the problem. By not having qualified paths and consequently not recognizing 
that the majority of partitions were under the tbl location, we ended up 
listing and loading block metadata for the partition files twice, once when we 
listed the files under tbl location and once for each partition that we 
incorrectly marked as not being a descendant of tbl location. Is this correct?


-- 
To view, visit http://gerrit.cloudera.org:8080/5743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c881b7cb155032b82fba0e29350ca31de388d55
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to