Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5389/6/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 677: output_unmatched_batch_->Reset(); > Not sure I understand - where is MarkNeedsDroopCopy set? It's set in BufferedTupleStream::GetNextInternal() (this code really needs to be cleaned up - the way BufferedTupleStream advances from one unpinned block to the next is really complicated and brittle). -- To view, visit http://gerrit.cloudera.org:8080/5389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I175b32dd9031e51218b38c37693ac3e31dfab47b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
