Joe McDonnell has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5768/1//COMMIT_MSG Commit Message: Line 12: There is a limitation to this fix: > To fix this we might consider changing Expr.computeNumDistinctValues() to c I agree that this is what we should be doing. My first thought was that this would be substantially more complicated and might require overriding this function in several classes. Now that I'm looking at it again, I think it wouldn't break anything to do this in Expr and then only override CaseExpr.java. I will modify this transaction to try this out. -- To view, visit http://gerrit.cloudera.org:8080/5768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21dbdaad8452b7e58c477612b47847dccd9d98d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-HasComments: Yes
