Jim Apple has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5640/3//COMMIT_MSG Commit Message: Line 13: In addition to bumping the version of pytest (and related modules), > I can do that if you feel strongly about it. I think that would be good. In my experience; formatting or renaming changes that touch a large number of files or lines can obscure the tricky bits of more substantive changes when they are bundled. I'd expect the renames could be +2ed easily and so I'd suggest that one first before the pytest upgrade. Line 24: sed -i 's/TestMatrix/ImpalaTestMatrix/g' > OK, so this seemingly innocuous question opened up (what seems to me) a rea Filed https://issues.cloudera.org/browse/IMPALA-4812 and https://issues.cloudera.org/browse/IMPALA-4818. Can you comment out that one test and then verify that the "core" exploration strategy collects the same tests? Don't worry about "pairwise"; as far as I can tell that strategy is broken and unused. -- To view, visit http://gerrit.cloudera.org:8080/5640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40d129e0e63ca5bee126bac6ac923abb3c7e0a67 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
