Alex Behm has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. ......................................................................
Patch Set 3: (2 comments) I also added an extra safety after discussion this with Tim. We believe that some of our functions may return malformed timestamps, so it's safer to be defensive for now. http://gerrit.cloudera.org:8080/#/c/5791/3/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: Line 326: static inline void IntToChar(uint8_t* dst, int num, int len) { > WFM. Done Line 338: DCHECK(ts_value.IsValidDate()); > This ensures ts_value.date().year() is >= 0 and <= 9999, yes? Yes. Between 1400 and 9999 to be precise. -- To view, visit http://gerrit.cloudera.org:8080/5791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5713b3e0c27b739aae597a6911cf3b2ddd01f822 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
