Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation ......................................................................
IMPALA-4820: avoid writing unencrypted data during write cancellation The bug was that unencrypted data could be written to disk if the write was cancelled before it completed. This bug was introduced after Impala 2.8.0 was branched in the commit "IMPALA-3202,IMPALA-2079: rework scratch file I/O", so does not appear in any released versions of Impala. The fix is to only start decrypting data after the write is complete. Testing: Added a regression test that reproduced the problem (after adding a delay to the write). Change-Id: I956bae0685e863f30be23634b29aa076394db184 --- M be/src/common/global-flags.cc M be/src/runtime/disk-io-mgr.cc M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc 4 files changed, 73 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/5788/2 -- To view, visit http://gerrit.cloudera.org:8080/5788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I956bae0685e863f30be23634b29aa076394db184 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
