Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer ......................................................................
Patch Set 7: (5 comments) Thanks for the review. I addressed the open points in PS8. http://gerrit.cloudera.org:8080/#/c/5611/7/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: Line 325: self.execute_query("drop table %s" % qualified_table_name) > Not needed - it should be dropped with the unique_database The idea was to make the method leave nothing behind, so it may be run repeatedly. I changed it so it deletes the table before creating it, thinking that may make it more robust. PS7, Line 446: num_lines > num_rows? Done Line 447: query = "create table %s like %s stored as parquet" % \ > A while back someone who was more up-to-date on python suggested that it wa I don't feel strongly either, and the file contained both already, so I went with the one that seemed simpler. I'll ask mikeb and dknupp for advice. Line 465: assert l.max < r.min > Maybe this should be <=? E.g. consider two row groups that only have one va Yes. This will not matter for the table I used, but in general it covers more precisely what I wanted to express. Line 467: self.execute_query("drop table %s" % qualified_target_table) > Not needed - it should be dropped with the unique_database Done -- To view, visit http://gerrit.cloudera.org:8080/5611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8368ee58daa50c07a3b8ef65be70203eb941f619 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
