Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5743/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 775: for (Path location: locations) { loadBlockMetadata(location, partsByPath); } remove {} http://gerrit.cloudera.org:8080/#/c/5743/7/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: Line 445: } what's the case for logging instead of a precondition? since we control who calls this function and what parameters get passed, this doesn't look like a runtime error to me. -- To view, visit http://gerrit.cloudera.org:8080/5743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c881b7cb155032b82fba0e29350ca31de388d55 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
