Marcel Kornacker has posted comments on this change. Change subject: Impala ABM / LZCNT support ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/1/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 98: static inline uint32_t RoundUpToPowerOfTwoNoHw32(uint32_t v) { > One of the primary reasons I created this change was to probe exactly that let's discuss in person, but i think the function should be careful about bounds, not the caller. also, impala doesn't support unsigned column types, so there isn't really a need for unsigned arithmetic on user data. -- To view, visit http://gerrit.cloudera.org:8080/5821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
