Jim Apple has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5784/2/tests/query_test/test_cancellation.py File tests/query_test/test_cancellation.py: PS2, Line 195: if cls.exploration_strategy() != 'exhaustive': : cls.ImpalaTestMatrix.add_constraint(lambda v: v.get_value('cancel_delay') in [3]) > L196 will rarely if ever get executed, because the workload as derived from I don't quite see what you're getting at here. It seems like line 198-199 in HEAD get executed for every "core" run. In the history of this patch, line 195 was added because tests were too slow. Generally, I'd like to confine this patch to just derandomizing this method and worry about which test should be run later if we see a problem. -- To view, visit http://gerrit.cloudera.org:8080/5784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22cecfbe7c9a102f788d01eb80aa188579ef6d7e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
