Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page ......................................................................
Patch Set 13: Code-Review+1 (5 comments) I'll let MJ and/or Todd make a final pass. http://gerrit.cloudera.org:8080/#/c/5649/13/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: PS13, Line 85: [PRIMARY KEY (<varname>col_name</varname>[, ...]] This doesn't belong here. PS13, Line 244: <codeblock>CREATE TABLE [IF NOT EXISTS] <varname>db_name</varname>.]<varname>table_name</varname> : [COMMENT '<varname>table_comment</varname>'] : STORED AS KUDU : [TBLPROPERTIES ('<varname>key1</varname>'='<varname>value1</varname>', '<varname>key2</varname>'='<varname>value2</varname>', ...)] : AS : <varname>select_statement</varname></codeblock> This is not correct. You're missing the PRIMARY KEY and PARTITION BY clauses. PS13, Line 411: impala::username.kudu_t1 nit: I don't think this is a good example. I would be really surprised if someone actually created a Kudu table outside of Impala named as "impala::username....". Pls change the table name. http://gerrit.cloudera.org:8080/#/c/5649/13/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: PS13, Line 93: kudu.master_addresses That's the name of the table property. Can you verify that name of the impalad configuration param? PS13, Line 148: There is a many-to-many relationship : between the tablets and tablet servers, managed automatically by Kudu. Isn't more clear to say that each tablet server can store multiple tablets and that tablets are replicated across different tablet servers? -- To view, visit http://gerrit.cloudera.org:8080/5649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76dcb948dab08532fe41326b22ef78d73282db2c Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
