Michael Brown has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 2: # E101 - Reindent all lines. I moderately disagree with this being ignored. Can you talk about your reasonings for wanting to ignore it? PS1, Line 5: # E251 - Remove whitespace around parameter '=' sign. : # E301 - Add missing blank line. I strongly disagree with these being ignored. Can you talk about your reasonings for wanting to ignore them? http://gerrit.cloudera.org:8080/#/c/5829/1//COMMIT_MSG Commit Message: PS1, Line 7: Add .pep8rc for Impala's Python style What tools get affected by the presence of this? Can it stay in the top-level Impala directory, or do I need to copy it to my homedir? -- To view, visit http://gerrit.cloudera.org:8080/5829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65a99fc6e364eb1e49e21d0ba97546bc25f65a27 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
