Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5811/4/be/src/runtime/buffered-tuple-stream-v2.cc File be/src/runtime/buffered-tuple-stream-v2.cc: Line 326: LOG(INFO) << "Failed to get reservation for " << pages_.front().len(); I need to remove this log message. http://gerrit.cloudera.org:8080/#/c/5811/4/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: Line 100: if (ExecEnv::GetInstance()->buffer_pool() != nullptr) { Use exec-env directly. http://gerrit.cloudera.org:8080/#/c/5811/4/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 29: #include "runtime/tmp-file-mgr.h" // TODO: can we avoid this? Remove TODO Line 121: Status CheckSpillingEnabled(); This is currently dead code - can remove it. http://gerrit.cloudera.org:8080/#/c/5811/4/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 442: /// TODO: ownership semantics Need to fix this TODO -- To view, visit http://gerrit.cloudera.org:8080/5811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb47a818564ac19a6be4ca88db0578f4ea0b709 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
