Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/5816/2/be/src/exec/union-node.cc File be/src/exec/union-node.cc: PS2, Line 122: IsInSubplan() > I think we would either pass child_idx_ into isPassThrough() or call it som Done Line 123: > Move this into the Open() branch so we don't execute it unnecessarily. Done Line 126: DCHECK(!IsInSubplan()); > We need to think about the implications of this. This could increase resour Done. Disabled passthrough in subplans. The last row batch of each child is marked with the DeepCopy flag. http://gerrit.cloudera.org:8080/#/c/5816/2/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: PS2, Line 438: Verify > Verify (caps) Done PS2, Line 442: > > Make these references with & to avoid copying the vector. Done PS2, Line 442: const > Don't need std::, we automatically import it in common/names.h. Done -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
