Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/model_translator.py File tests/comparison/model_translator.py: PS1, Line 534: 1) Why 1 here? Are we expecting there to be several "INSERT" keywords in the query sql? http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/query.py File tests/comparison/query.py: Line 705: (CONFLICT_ACTION_DEFAULT, I see that you explained what these mean below, but it's not to perfectly clear to me. Maybe explain what these mean exactly here too? Conflict is when there is a row with the same primary key as you're trying to insert, right? Ignore means insert anyways (so duplicate the primary key?). What is default exactly? PS1, Line 727: ng a K inserting into a Kudu table http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/statement_generator.py File tests/comparison/statement_generator.py: Line 70: if dml_table.primary_keys: Add a comment that if the table has primary keys then it's a Kudu table and Kudu supports UPSERT. (Otherwise upsert is not generated because it's not supported) -- To view, visit http://gerrit.cloudera.org:8080/5795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6382f6ab22ba29c117e39a5d90592d3637df4b25 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
