Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5848
Change subject: IMPALA-4809: Add Stability for codegen constants ...................................................................... IMPALA-4809: Add Stability for codegen constants Having two boolean parameters to a constructor is error prone, so I thought instead we could express the 'constance' of values by using an enum class. I chose 'Stability' as a name since one can imagine extending this to other semi-stable things in a spectrum between Literal expressed constant, runtime constant, query-local constant, memoizable constexpr, dynamic variable. Right now those terms may be overloaded into a single notion in the sense of is_constant() but they are quite distinct concepts. For example, CPU flags are RUNTIME_CONSTANT, while query options are QUERY_CONSTANT. Testing: Going to run standard test suite. There should be no side effects at all from this change. Change-Id: I0431bcd84b908bcf130a6d618f57f8f7c5498428 --- M be/src/exprs/expr.cc M be/src/exprs/expr.h M be/src/exprs/literal.cc M be/src/exprs/null-literal.h M be/src/exprs/slot-ref.cc 5 files changed, 38 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/5848/1 -- To view, visit http://gerrit.cloudera.org:8080/5848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0431bcd84b908bcf130a6d618f57f8f7c5498428 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]>
