Alex Behm has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5815/1//COMMIT_MSG Commit Message: Line 7: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of describe the fix not the bug: DROP DATABASE CASCADE removes caching directives http://gerrit.cloudera.org:8080/#/c/5815/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: Line 1279: uncacheTable(removedDb.getTable(tableName)); It's a little tricky to figure out, but I think we may have to lock these tables. For example, there might be a concurrent request for caching a table/partition and there could be a concurrent deepCopy() of the msTbl which may not be safe with removing entries from the msTbl properties. Might be worth looking into at least. http://gerrit.cloudera.org:8080/#/c/5815/1/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java File fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java: Line 163: org.apache.hadoop.hive.metastore.api.Partition part) throws ImpalaException { tab http://gerrit.cloudera.org:8080/#/c/5815/1/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: Line 212: """The DROP DATABASE CASCADE should properly drop all impacted cache directives Remove "The" Line 213: IMPALA-2518""" use IMPALA-2518 as a prefix to comment (like we typically do) Line 215: # Creates `cachedb` database with some cached tables and partitions Populates the 'cachedb' database... -- To view, visit http://gerrit.cloudera.org:8080/5815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ef5a33e06728c2b3f833a0309d9da64dce7b88 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
