anujphadke has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5800/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test File testdata/workloads/functional-query/queries/QueryTest/aggregation.test: PS2, Line 26: > please add a space Done PS2, Line 30: > so all of these match postgres now? variance function needed similar changes like std_dev. Here is the output from postgres. Last login: Thu Feb 2 12:32:04 on ttys000 "/Applications/Postgres.app/Contents/Versions/9.6/bin/psql" -p5432 -d "aphadke" aphadke-MBP-2:~ aphadke$ "/Applications/Postgres.app/Contents/Versions/9.6/bin/psql" -p5432 -d "aphadke" psql (9.6.1) Type "help" for help. aphadke=# select stddev_samp(56); stddev_samp ------------- (1 row) aphadke=# select stddev(56); stddev -------- (1 row) aphadke=# select stddev_pop(56); stddev_pop ------------ 0 (1 row) aphadke=# select var_pop(56); var_pop --------- 0 (1 row) aphadke=# select var_samp(56); var_samp ---------- (1 row) aphadke=# select variance(56); variance ---------- (1 row) aphadke=# -- To view, visit http://gerrit.cloudera.org:8080/5800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide8af752cd8a2e554a2cd5a1ec948967a80de1fe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
