Alex Behm has posted comments on this change. Change subject: IMPALA-4675 Lowercase parquet column names prior to matching ......................................................................
Patch Set 2: (2 comments) Thanks for taking this on! Will you be able to add test cases? Please reach out of you need figuring out how to do that and/or what tests are appropriate. http://gerrit.cloudera.org:8080/#/c/5891/2/be/src/exec/parquet-metadata-utils.cc File be/src/exec/parquet-metadata-utils.cc: Line 537: int ParquetSchemaResolver::FindChildWithName(SchemaNode* node, update the comment on FindChildWitName() in the .h file to reflect the case-insensitivity Line 542: std::transform(element_name_lower.begin(), element_name_lower.end(), use boost::algorithm::iequals() instead add a using directive above -- To view, visit http://gerrit.cloudera.org:8080/5891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Nathan Salmon <nathan.gsal...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-HasComments: Yes
