Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5840/2/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: PS2, Line 140: } else if (scanner_schema.num_columns() > tuple_desc->slots().size()) { : state_->LogError(ErrorMsg::Init(TErrorCode::KUDU_COL_MISMATCH, : scan_node_->table_->name(), scanner_schema.num_columns(), : tuple_desc->slots().size())); After thinking about this more, I don't think it should be possible to find more than we expected in planning. The reason is that in planning we get a scan token which knows about the expected columns. That gets deserialized here, so there shouldn't be any new cols that could be added to it. Even if new cols were added to the table. I made this a DCHECK but I'll double check my thinking with the Kudu team. -- To view, visit http://gerrit.cloudera.org:8080/5840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d43f5bb9811e728ad592933066d006c8fb4553a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
