Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1288: {{ false, 2230, 5, 3 }, { false, 2230, 5, 3 }} }, this isn't super-easy to read, how about having the v1 and v2 results on separate lines and lined up (so they're easy to compare)? or better yet, making expected[1] optional, and if it's missing it's an indication that v1 and v2 have the same result? Line 1345: for (int v2 = 0; v2 <= 1; ++v2) { for (int v2: {0, 1}) will do the same -- To view, visit http://gerrit.cloudera.org:8080/5933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes