Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 5510: Decimal8Value(4) > Probably doesn't matter but this can be Decimal4Value(), right ? Same below Yeah that's right. Rather than adjusting all this by hand, I think we should just convert this to the table-driven style (and then the correct Decimal*Value is chosen for us, and we can run these cases with v2=1). So how about I save that (looks like there's a handful of them using the wrong size). -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
