Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges. ......................................................................
Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/5774/1/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: Line 799: if (!childFragment.refsNullableTupleId(partitionExprs)) { combine with preceding if http://gerrit.cloudera.org:8080/#/c/5774/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: Line 386: * Returns true if 'exprs' reference a tuple that is made nullable in this fragment. "in this fragment but not in any of its input fragments" Line 390: List<TupleId> groupingExprTids = Lists.newArrayList(); remove the reference to grouping, it's overly specific. -- To view, visit http://gerrit.cloudera.org:8080/5774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I121222179378e56836422a69451d840a012c9e54 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
