Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 ......................................................................
Patch Set 2: Verified there is no perf regression with decimal_v2=false using following query: select sum(cast(l_quantity as DECIMAL(12,1)) + cast(l_extendedprice as DECIMAL(12,1)) + cast(l_discount as DECIMAL(12,1)) + cast(l_tax as DECIMAL(12,1))) from tpch20_parquet.lineitem; Avg: 2.23s With decimal_v2 to true, the query slowed down quite a bit: Avg: 4.53s Verified that the optimized IR already had constant propagated. -- To view, visit http://gerrit.cloudera.org:8080/5950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: No
