Henry Robinson has posted comments on this change. Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5971/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS1, Line 1562: num_remaining_fragment_instances_.Load(); > Just print "num_remaining" ? probably should print num_remaining for consistency but - on x86, Load() translates to a mov plus a compiler barrier, because loads on x86 have acquire semantics. So the bus doesn't get locked. -- To view, visit http://gerrit.cloudera.org:8080/5971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7599780785c4e9306711f535bf4726a247873e2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
