Jim Apple has posted comments on this change. Change subject: IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5978/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars > Is our policy 72 chars for commit messages then? It seems to be common practice. $ git log | grep -oE '^ ([^ ].*)$' | cut -d ' ' -f 5- | awk '{print length;}' | sort -n | uniq -c ... 941 65 1059 66 1197 67 1680 68 1435 69 1426 70 1137 71 1118 72 368 73 325 74 349 75 327 76 ... -- To view, visit http://gerrit.cloudera.org:8080/5978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
