David Knupp has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6002/1/bin/run-all-tests.sh File bin/run-all-tests.sh: PS1, Line 95: around in many formats. Nit. I had to read this sentence a couple of times. How do you feel about this wording? "too large to load in all of the formats required by exhaustive mode." Or something like that. http://gerrit.cloudera.org:8080/#/c/6002/2/tests/custom_cluster/test_spilling.py File tests/custom_cluster/test_spilling.py: PS2, Line 57: super(CustomClusterTestSuite, cls).setup_class() What's the reason to not have this at the very top of the method? -- To view, visit http://gerrit.cloudera.org:8080/6002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6bd5bbd380e636d680368e908519b042d79dfec Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
