Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts ......................................................................
Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: PS9, Line 303: round > Otherwise this is a behavior change. dv.ToInt detects overflow. to_type(d Yeah, I got that. What I'm saying is why not remove the 'round' paramter since we can't use it anyway? I originally suggested adding that parameter assuming it would eliminate the need for the else-clause, but since that's not the case, why keep the dead (and untested) code? http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1503: { true, 0, 3, 0 }}}, > due to scaling, we get coverage anyway as 0.45 ends in 5. I can add it, bu okay. i missed that the scale=1 case covers that. http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: PS9, Line 43: precise > Well, there aren't enough bits in the floating point multiplier to fully re sure, fixing in a separate change sounds fine. If there's no jira for that, can you open one and note the number in the todo? PS9, Line 119: DCHECK > Couldn't do this. DCHECK_EQ doesn't know how to print int128_t and larger ah, okay. http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 113: if (divisor == 1) { what's this for? is it an optimization for scale==0 case? -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
