Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py ......................................................................
IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py This change enables decimal_v2 for casting to decimal except for cases which involve rounding/truncation. In which case, we only enable decimal_v2 for casting from numbers to decimal. Due to prior misunderstanding, some of the changes made in commit 2088cf2 weren't necessary. By default, Impala interprets floating numbers as decimal unless they exceed the maximum decimal type supported. This change also removess a minor quirk: previously, the test will revert to using string to decimal casting for numbers larger than 2^63-1. This is unnecessary as Impala is able to treat numbers larger than that bound as decimal type. Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3 Reviewed-on: http://gerrit.cloudera.org:8080/5989 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Impala Public Jenkins --- M tests/query_test/test_decimal_casting.py 1 file changed, 27 insertions(+), 36 deletions(-) Approvals: Impala Public Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]>
