Alex Behm has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5980/2/fe/src/main/java/org/apache/impala/util/DisjointSet.java File fe/src/main/java/org/apache/impala/util/DisjointSet.java: PS2, Line 49: private final IdentityHashMap<Set<T>, Object> uniqueSets_ = : new IdentityHashMap<Set<T>, Object>(); > nice idea :) It was pretty much your idea :) PS2, Line 111: checkState(removedValue == DUMMY_VALUE); > I think checking for not NULL is also ok. This one seems more explicit because if we got back a non-NULL value that is not DUMMY_VALUE, then something bad has happened. -- To view, visit http://gerrit.cloudera.org:8080/5980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I609c8795c09becd78815605ea8e82e2f99e82212 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
