Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI ......................................................................
Patch Set 1: (5 comments) this is pretty cool. Got a couple of suggestions about organisation and presentation, let me know what you think. http://gerrit.cloudera.org:8080/#/c/6013/1/be/src/util/thread.cc File be/src/util/thread.cc: PS1, Line 209: RegisterUrlCallback Rather than adding another top-level link, consider making two tabs on the threadz.tmpl page - maybe thread overview and JVM threads for now. See query_detail_tabs.tmpl for how to add tabs to a page in bootstrap. PS1, Line 234: bool track_jvm_threads, how about just making this a member of ThreadMgr? Actually - I don't think ThreadMgr needs to know about JVM threads at all, right? Why not just have something like: void ThreadOverviewUrlCallback(...) { thread_mgr->GetThreadOverview(document); GetJvmThreadOverview(document); } and then you avoid having to pass track_jvm_threads to ThreadMgr at all, which is good because it doesn't really track or manage those threads. Line 260: << status.GetDetail(); return, then remove else { } PS1, Line 262: jvmThreadsVal C++ naming styles http://gerrit.cloudera.org:8080/#/c/6013/1/www/jvm-threadz.tmpl File www/jvm-threadz.tmpl: PS1, Line 35: Is n Native -- To view, visit http://gerrit.cloudera.org:8080/6013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id497043ab33dcf107a562f0b1ccd5c46095d397f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
