Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup ......................................................................
IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup OpenSSL initialization functions are not threadsafe and are currently called by both thrift, squeasel, and the Kudu client. This change forces thrift to initialize OpenSSL on startup by adding a TSSLSocketFactory to the AuthManager which initializes OpenSSL upon creation and lives the lifetime of the process. Then, squeasel is configured to skip the OpenSSL initialization. TODO: When the Kudu client supports a flag to disable its initialization path (KUDU-1738), Impala will call that. In the meantime, there will continue to be some small likelihood of a race. Also updates Squeasel in thirdparty to c304d3f3481b07bf153979155f02e0aab24d01de This is necessary to configure squeasel not to init OpenSSL. Change-Id: I245a8a001103ddca7f07349faa82bbb5b9fe3ab0 Reviewed-on: http://gerrit.cloudera.org:8080/6027 Reviewed-by: Sailesh Mukil <[email protected]> Reviewed-by: Matthew Jacobs <[email protected]> Reviewed-by: Henry Robinson <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/rpc/authentication.cc M be/src/rpc/authentication.h M be/src/thirdparty/squeasel/squeasel.c M be/src/util/CMakeLists.txt M be/src/util/webserver.cc 5 files changed, 54 insertions(+), 29 deletions(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, approved Matthew Jacobs: Looks good to me, approved Sailesh Mukil: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/6027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245a8a001103ddca7f07349faa82bbb5b9fe3ab0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
