Dan Hecht has posted comments on this change. Change subject: IMPALA-4877: fix precedence of unary -/+ ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6044/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1382: { "2.0 / 3.0", > add variant -2.0/-3.0 Done Line 1385: { "-2.0 / 3.0", > add variants -(2.0/3.0) and 2.0/-3.0 Added 2.0/-3.0, but -(2.0/3.0) still produces a double. That's how "-2.0/3.0" was being parsed before this change, and results in a double due to IMPALA-3437. -- To view, visit http://gerrit.cloudera.org:8080/6044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39cf388ae6e37e1b1e12ddea5fd3878c9c2620d1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
