Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts ......................................................................
Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: PS12, Line 49: double > shouldn't this be T? No, T may not have enough precision to hold the value of 10^scale - look at the old code, which also does the multiplication in double. PS12, Line 52: max_value < 0 > why is the max_value < 0 check needed? If we cast to a decimal type whose underlying width is not large enough to hold the precision, this will become true. Make it a DCHECK? This should be impossible, guaranteed by the type system. -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
